-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest] Fix package info request returning 500 #61712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Feature:EPM
Fleet team's Elastic Package Manager (aka Integrations) project
v7.8.0
Team:Fleet
Team label for Observability Data Collection Fleet team
labels
Mar 27, 2020
Pinging @elastic/ingest-management (Feature:EPM) |
neptunian
approved these changes
Mar 30, 2020
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 3, 2020
* master: [Drilldowns] Dashboard state fixes for drilldowns (elastic#61457) allow null for filterQuery (elastic#62310) [ML] call job validation endpoint with complete payload (elastic#62331) removing configuration from agents (elastic#62290) Allow Enterprise license for service map (elastic#62371) docs: updates to apm agent config (elastic#61893) [Ingest] Fix package info request returning 500 (elastic#61712) move crypto to server utils (elastic#62344) Start indexing documents by default (elastic#62159) [Endpoint] Update host field accordion (elastic#61878) Add more definitions about Ingest Management (elastic#62049)
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
Added to PRs automatically when the are determined to be missing a backport.
label
Apr 6, 2020
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Apr 7, 2020
* Fix 500 package info request error * Fix installed packages page not loading Co-authored-by: Elastic Machine <[email protected]>
jen-huang
added a commit
that referenced
this pull request
Apr 7, 2020
* Fix 500 package info request error * Fix installed packages page not loading Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
removed
the
backport missing
Added to PRs automatically when the are determined to be missing a backport.
label
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:EPM
Fleet team's Elastic Package Manager (aka Integrations) project
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.8.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #61631 where a package info request was sent without a proper package key string, resulting in a 500 error response.
I also noticed that the Installed packages tab was loading indefinitely because no installed packages were detected so fixed that as well. (As we always install the system package by default, this state wouldn't come up normally, but currently installed packages are not found properly due to #61679.)